Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752598Ab3IOEyr (ORCPT ); Sun, 15 Sep 2013 00:54:47 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:60749 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751590Ab3IOEyp (ORCPT ); Sun, 15 Sep 2013 00:54:45 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: Stephen Warren , Lists linaro-kernel , Patch Tracking , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-kernel@lists.infradead.org" , Stephen Warren Subject: Re: [PATCH 211/228] cpufreq: tegra: remove calls to cpufreq_notify_transition() Date: Sun, 15 Sep 2013 07:05:48 +0200 Message-ID: <32077984.uYNhUh2ogt@vostro.rjw.lan> User-Agent: KMail/4.10.5 (Linux/3.11.0+; KDE/4.10.5; x86_64; ; ) In-Reply-To: References: <52339729.7030309@wwwdotorg.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 37 On Saturday, September 14, 2013 09:39:31 AM Viresh Kumar wrote: > On 14 September 2013 04:22, Stephen Warren wrote: > > I wonder if this series is bisectable? Perhaps I should just go and read > > the rest of the series, but I presume there's a patch somewhere else > > that adds those two cpufreq_notify_transition() to the cpufreq core. > > Either that happens before this patch (in which case listeners will get > > two notifications each time; perhaps that is safe?), or after this patch > > (in which case with just this patch applied, no notifications will be > > sent until a later patch! > > Hmm.. Good Catch.. > > So, yes git bisect would be compilable but not runnable.. As we are > already serialized notifications and so two PRE notifications will > generate a crash.. > > But I don't want to get all that in a single patch as that would be: > > 40 files changed, 192 insertions(+), 623 deletions(-) > > And that would be hard to review it.. > > Any suggestions? Well, I guess you can assume that everyone has a chance to review the series by now and send it as one patch in the next iteration. A patch that adds 192 lines of code isn't shockingly large by any measure. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/