Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757230Ab3IPIdc (ORCPT ); Mon, 16 Sep 2013 04:33:32 -0400 Received: from mail-bk0-f43.google.com ([209.85.214.43]:57794 "EHLO mail-bk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756873Ab3IPId2 (ORCPT ); Mon, 16 Sep 2013 04:33:28 -0400 From: Thierry Reding To: Greg Kroah-Hartman , Linus Walleij , Stephen Warren , Wolfram Sang , Grant Likely , Rob Herring , Benjamin Herrenschmidt , Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 6/9] of/irq: Propagate errors in of_irq_to_resource_table() Date: Mon, 16 Sep 2013 10:32:03 +0200 Message-Id: <1379320326-13241-7-git-send-email-treding@nvidia.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1379320326-13241-1-git-send-email-treding@nvidia.com> References: <1379320326-13241-1-git-send-email-treding@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 41 Now that all helpers return precise error codes, this function can propagate these errors to the caller properly. Signed-off-by: Thierry Reding --- drivers/of/irq.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 57396fd..c33a7fd 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -418,11 +418,17 @@ int of_irq_count(struct device_node *dev) int of_irq_to_resource_table(struct device_node *dev, struct resource *res, int nr_irqs) { - int i; + int i, ret; + + for (i = 0; i < nr_irqs; i++, res++) { + ret = __of_irq_to_resource(dev, i, res); + if (ret <= 0) { + if (ret < 0) + return ret; - for (i = 0; i < nr_irqs; i++, res++) - if (!of_irq_to_resource(dev, i, res)) break; + } + } return i; } -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/