Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757304Ab3IPJWG (ORCPT ); Mon, 16 Sep 2013 05:22:06 -0400 Received: from eu1sys200aog125.obsmtp.com ([207.126.144.159]:46773 "EHLO eu1sys200aog125.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755425Ab3IPJWF convert rfc822-to-8bit (ORCPT ); Mon, 16 Sep 2013 05:22:05 -0400 From: Denis CIOCCA To: Lars-Peter Clausen Cc: Jonathan Cameron , Lee Jones , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "jic23@cam.ac.uk" , "arnd@arndb.de" , "linus.walleij@linaro.org" , "linux-iio@vger.kernel.org" Date: Mon, 16 Sep 2013 11:21:12 +0200 Subject: Re: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names Thread-Topic: [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names Thread-Index: Ac6yvhflMY+grlOtRX+M5RtmvVSXXg== Message-ID: <5236CD88.10809@st.com> References: <1378817379-8238-1-git-send-email-lee.jones@linaro.org> <1378817379-8238-15-git-send-email-lee.jones@linaro.org> <52345330.4050707@kernel.org> <5234562D.5050803@kernel.org> <5236C259.6050701@metafoo.de> In-Reply-To: <5236C259.6050701@metafoo.de> Accept-Language: it-IT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 acceptlanguage: it-IT, en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 31 Hi Lars, > On 09/14/2013 02:27 PM, Jonathan Cameron wrote: >> On 09/14/13 13:14, Jonathan Cameron wrote: >>> On 09/10/13 13:49, Lee Jones wrote: >>>> Some of ST's sensors are appended with their sensor type and some >>>> are not. For consistency we're extending the same naming convention >>>> throughout. >>>> >>>> Signed-off-by: Lee Jones >>> Honestly I don't care either way on these, but consistency would definitely >>> be good so applied to the togreg branch of iio.git >>> >>> Thanks, >> Actually change of plan. I'm going to hold off on these as this an ABI change. >> Iritating though having these as completely inconsistent is, changing this >> will change device identification from userspace which is not a good idea. >> >> Sorry Lee, but we really shouldn't do this. I should have picked up on this >> in the original driver reviews but that's hindsight for you. > I think those with the suffix are the ones where you have accel and gyro in > the same package, the ones without the suffix are pure accelerometers. Yes You are right. I've used this kind of logic... What do you think about? Denis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/