Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752649Ab3IPMhI (ORCPT ); Mon, 16 Sep 2013 08:37:08 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49431 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751243Ab3IPMhD (ORCPT ); Mon, 16 Sep 2013 08:37:03 -0400 Date: Mon, 16 Sep 2013 14:36:45 +0200 From: Peter Zijlstra To: Mel Gorman Cc: Rik van Riel , Srikar Dronamraju , Ingo Molnar , Andrea Arcangeli , Johannes Weiner , Linux-MM , LKML Subject: Re: [PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update Message-ID: <20130916123645.GD9326@twins.programming.kicks-ass.net> References: <1378805550-29949-1-git-send-email-mgorman@suse.de> <1378805550-29949-8-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378805550-29949-8-git-send-email-mgorman@suse.de> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 28 On Tue, Sep 10, 2013 at 10:31:47AM +0100, Mel Gorman wrote: > A THP PMD update is accounted for as 512 pages updated in vmstat. This is > large difference when estimating the cost of automatic NUMA balancing and > can be misleading when comparing results that had collapsed versus split > THP. This patch addresses the accounting issue. > > Signed-off-by: Mel Gorman > --- > mm/mprotect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 94722a4..2bbb648 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -145,7 +145,7 @@ static inline unsigned long change_pmd_range(struct vm_area_struct *vma, > split_huge_page_pmd(vma, addr, pmd); > else if (change_huge_pmd(vma, pmd, addr, newprot, > prot_numa)) { > - pages += HPAGE_PMD_NR; > + pages++; But now you're not counting pages anymore.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/