Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220Ab3IPNGN (ORCPT ); Mon, 16 Sep 2013 09:06:13 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:40827 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751207Ab3IPNGK (ORCPT ); Mon, 16 Sep 2013 09:06:10 -0400 MIME-Version: 1.0 In-Reply-To: <1379277856-24571-4-git-send-email-sre@debian.org> References: <1379277856-24571-1-git-send-email-sre@debian.org> <1379277856-24571-4-git-send-email-sre@debian.org> From: Javier Martinez Canillas Date: Mon, 16 Sep 2013 15:05:49 +0200 Message-ID: Subject: Re: [RFCv2 3/3] ARM: dts: N900: Add SSI information To: Sebastian Reichel Cc: Sebastian Reichel , Linus Walleij , Shubhrajyoti Datta , Carlos Chinea , Paul Walmsley , Kevin Hilman , Tony Lindgren , Russell King , Grant Likely , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Linux Kernel , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7348 Lines: 188 On Sun, Sep 15, 2013 at 10:44 PM, Sebastian Reichel wrote: > Add SSI device tree data for OMAP34xx and Nokia N900. > > Signed-off-by: Sebastian Reichel > --- > Documentation/devicetree/bindings/hsi/omap_ssi.txt | 73 ++++++++++++++++++++++ > arch/arm/boot/dts/omap3-n900.dts | 8 +++ > arch/arm/boot/dts/omap34xx.dtsi | 49 +++++++++++++++ > 3 files changed, 130 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hsi/omap_ssi.txt > > diff --git a/Documentation/devicetree/bindings/hsi/omap_ssi.txt b/Documentation/devicetree/bindings/hsi/omap_ssi.txt > new file mode 100644 > index 0000000..e3597eb > --- /dev/null > +++ b/Documentation/devicetree/bindings/hsi/omap_ssi.txt > @@ -0,0 +1,73 @@ > +OMAP SSI controller bindings > + > +Required properties: > +- compatible: Should be set to the following value > + ti,omap3-ssi (applicable to OMAP34xx devices) > +- ti,hwmods: Name of the hwmod associated to the controller, which > + is "ssi". > +- reg: Contains SSI register address range (base address and > + length). > +- reg-names: Contains the names of the address ranges. It's > + expected, that "sys" and "gdd" address ranges are > + provided. > +- interrupts: Contains the interrupt information for the controller. > +- interrupt-names: Contains the names of the interrupts. It's expected, > + that "gdd_mpu" is provided. > +- ranges Required as an empty node > +- #address-cells Should be set to <1> > +- #size-cells Should be set to <1> > + > +Each port is represented as a sub-node of the ti,omap3-ssi device. > + > +Required Port sub-node properties: > +- compatible: Should be set to the following value > + ti,omap3-ssi-port (applicable to OMAP34xx devices) > +- reg: Contains port's register address range (base address > + and length). > +- reg-names: Contains the names of the address ranges. It's > + expected, that "tx" and "rx" address ranges are > + provided. > +- interrupt-parent Should be a phandle for the interrupt controller > +- interrupts: Contains the interrupt information for the port. > +- interrupt-names: Contains the names of the interrupts. It's expected, > + that "mpu_irq0" and "mpu_irq1" are provided. > +- ti,ssi-cawake-gpio: Defines which GPIO pin is used to signify CAWAKE > + events for the port. This is an optional board-specific > + property. If it's missing the port will not be > + enabled. > + > +Example for Nokia N900: > + > +ssi-controller@48058000 { > + compatible = "ti,omap3-ssi"; > + ti,hwmods = "ssi"; > + > + reg = <0x48058000 0x1000>, > + <0x48059000 0x1000>; > + reg-names = "sys", > + "gdd"; > + > + interrupts = <55>; > + interrupt-names = "gdd_mpu"; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + ssi-port@0 { > + compatible = "ti,omap3-ssi-port"; > + > + reg = <0x4805a000 0x800>, > + <0x4805a800 0x800>; > + reg-names = "tx", > + "rx"; > + > + interrupt-parent = <&intc>; > + interrupts = <51>, > + <52>; > + interrupt-names = "mpu_irq0", > + "mpu_irq1"; > + > + ti,ssi-cawake-gpio = <&gpio5 23 GPIO_ACTIVE_HIGH>; /* 151 */ > + } > +} > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > index 0582356..cc4a3e2 100644 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -186,6 +186,14 @@ > power = <50>; > }; > > +&ssi_port1 { > + ti,ssi-cawake-gpio = <&gpio5 23 GPIO_ACTIVE_HIGH>; /* 151 */ > +}; > + > +&ssi_port2 { > + status = "disabled"; > +}; > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&uart1_pins>; > diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi > index 5355d61..393b7a7 100644 > --- a/arch/arm/boot/dts/omap34xx.dtsi > +++ b/arch/arm/boot/dts/omap34xx.dtsi > @@ -25,4 +25,53 @@ > clock-latency = <300000>; /* From legacy driver */ > }; > }; > + > + ocp { > + ssi: ssi-controller@48058000 { > + compatible = "ti,omap3-ssi"; > + ti,hwmods = "ssi"; > + > + reg = <0x48058000 0x1000>, > + <0x48059000 0x1000>; > + reg-names = "sys", > + "gdd"; > + > + interrupts = <55>; > + interrupt-names = "gdd_mpu"; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + ssi_port1: ssi-port@0 { > + compatible = "ti,omap3-ssi-port"; > + > + reg = <0x4805a000 0x800>, > + <0x4805a800 0x800>; > + reg-names = "tx", > + "rx"; > + > + interrupt-parent = <&intc>; > + interrupts = <51>, > + <52>; > + interrupt-names = "mpu_irq0", > + "mpu_irq1"; > + }; > + > + ssi_port2: ssi-port@1 { > + compatible = "ti,omap3-ssi-port"; > + > + reg = <0x4805b000 0x800>, > + <0x4805b800 0x800>; > + reg-names = "tx", > + "rx"; > + > + interrupt-parent = <&intc>; > + interrupts = <53>, > + <54>; > + interrupt-names = "mpu_irq0", > + "mpu_irq1"; > + }; > + }; > + }; > }; > -- > 1.8.4.rc3 Hi Sebastian, Is the Synchronous Serial Interface (SSI) only supported by OMAP34xx/OMAP35xx SoC and not by OMAP36xx/OMAP37xx SoC? I'm asking this since if SSI is supported by both we should add the device nodes in omap3.dtsi instead of omap34xx.dtsi. I thought that all OMAP3 SoC supported SSI and all OMAP4 SoC supported HSI but I guess I was wrong... Thanks a lot and best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/