MIME-Version: 1.0
In-Reply-To: <CAErSpo6475cSMDtdk2ywFUUyb_szOFVdUy9Pm0DjnRTuiCVPhw@mail.gmail.com>
References: <20130529222955.10627.50429.stgit@bhelgaas-glaptop>
 <CAErSpo7s1m=6WvgeVOQ3Zj=mU8=+13pT4hJ8k5-KkrDDGOU+5w@mail.gmail.com>
 <20130613183315.GH10979@localhost> <CAErSpo6475cSMDtdk2ywFUUyb_szOFVdUy9Pm0DjnRTuiCVPhw@mail.gmail.com>
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Mon, 16 Sep 2013 07:49:59 -0600
Message-ID: <CAErSpo6eSCzUAyP4quc77-pts-=7GzjYeG2EbGbL8onbG9=SKQ@mail.gmail.com>
Subject: Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free
To: Kent Overstreet <kmo@daterainc.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Gu Zheng <guz.fnst@cn.fujitsu.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2024
Lines: 51

[update Kent's email address]

On Mon, Sep 16, 2013 at 7:40 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
> On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet
> <koverstreet@google.com> wrote:
>> On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote:
>>> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>>> > This fixes a copy and paste error introduced by 9f060e2231
>>> > ("block: Convert integrity to bvec_alloc_bs()").
>>> >
>>> > Found by Coverity (CID 1020654).
>>> >
>>> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>>> > ---
>>> >  fs/bio-integrity.c |    2 +-
>>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >
>>> > diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
>>> > index 8fb4291..45e944f 100644
>>> > --- a/fs/bio-integrity.c
>>> > +++ b/fs/bio-integrity.c
>>> > @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
>>> >                 mempool_destroy(bs->bio_integrity_pool);
>>> >
>>> >         if (bs->bvec_integrity_pool)
>>> > -               mempool_destroy(bs->bio_integrity_pool);
>>> > +               mempool_destroy(bs->bvec_integrity_pool);
>>> >  }
>>> >  EXPORT_SYMBOL(bioset_integrity_free);
>>>
>>> Kent, do you want to chime in on this?  Looks like an obvious error to
>>> me, but maybe I'm missing something and we should teach Coverity to
>>> shut up about it.
>>
>> Sorry - no, this is definitely a bug:
>>
>> Acked-by: Kent Overstreet <koverstreet@google.com>
>
> From my v3.12-rc1 reminder list: what's going on with this patch?
>
> It's been acked, Gu asked whether he could include it in some
> patchset, I see a Sep 11 2013 patch from Gu upstream already
> (bc5c8f078), but this patch (from May 29 2013) still hasn't gone
> anywhere.  Why is this so hard?
>
> Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/