Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751945Ab3IPXrm (ORCPT ); Mon, 16 Sep 2013 19:47:42 -0400 Received: from gate.crashing.org ([63.228.1.57]:60768 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685Ab3IPXrj (ORCPT ); Mon, 16 Sep 2013 19:47:39 -0400 Message-ID: <1379375239.3721.51.camel@pasglop> Subject: Re: "memory" binding issues From: Benjamin Herrenschmidt To: Olof Johansson Cc: Stephen Warren , "devicetree@vger.kernel.org" , Linux Kernel list , Marek Szyprowski , Stephen Warren , Rob Herring , Grant Likely Date: Tue, 17 Sep 2013 09:47:19 +1000 In-Reply-To: References: <1379300274.4098.77.camel@pasglop> <52372F2A.2050003@wwwdotorg.org> <1379371567.3721.46.camel@pasglop> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 25 On Mon, 2013-09-16 at 15:48 -0700, Olof Johansson wrote: > > A node that has a "reg" property should have the corresponding unit > > address. > > No, absolutely _NOT_ a requirement. Unit address is only required if > needed to disambiguate two properties with the same name. > > If there are no ambiguities, then leaving off the unit address is much > preferred. I disagree :-) Also this would be only true of our find_node_by_path was capable of handling it, which it isn't. Thus you end up with generic code looking for /memory and finding nothing ... Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/