Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752045Ab3IPXsw (ORCPT ); Mon, 16 Sep 2013 19:48:52 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:54801 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044Ab3IPXss (ORCPT ); Mon, 16 Sep 2013 19:48:48 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:1b02:6e3b:e5ff:fe16:f1aa] In-Reply-To: <1379375239.3721.51.camel@pasglop> References: <1379300274.4098.77.camel@pasglop> <52372F2A.2050003@wwwdotorg.org> <1379371567.3721.46.camel@pasglop> <1379375239.3721.51.camel@pasglop> Date: Mon, 16 Sep 2013 16:48:47 -0700 Message-ID: Subject: Re: "memory" binding issues From: Olof Johansson To: Benjamin Herrenschmidt Cc: Stephen Warren , "devicetree@vger.kernel.org" , Linux Kernel list , Marek Szyprowski , Stephen Warren , Rob Herring , Grant Likely Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1049 Lines: 30 On Mon, Sep 16, 2013 at 4:47 PM, Benjamin Herrenschmidt wrote: > On Mon, 2013-09-16 at 15:48 -0700, Olof Johansson wrote: >> > A node that has a "reg" property should have the corresponding unit >> > address. >> >> No, absolutely _NOT_ a requirement. Unit address is only required if >> needed to disambiguate two properties with the same name. >> >> If there are no ambiguities, then leaving off the unit address is much >> preferred. > > I disagree :-) Well, good thing you've got your own arch to litter the device trees with unit specifiers in then. :) > Also this would be only true of our find_node_by_path was capable of > handling it, which it isn't. Thus you end up with generic code looking > for /memory and finding nothing ... Yes, this should be fixed. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/