Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752229Ab3IQIIz (ORCPT ); Tue, 17 Sep 2013 04:08:55 -0400 Received: from va3ehsobe006.messaging.microsoft.com ([216.32.180.16]:46205 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797Ab3IQIIv (ORCPT ); Tue, 17 Sep 2013 04:08:51 -0400 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -5 X-BigFish: VS-5(zz9371I103dK542I1432Izz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzz1de098h1de097hz2dh2a8h839h8e2h8e3h93fhd25hf0ah1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh15d0h162dh1631h1758h18e1h1946h19b5h1ad9h1b0ah1b2fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e1dh1fe8h1ff5hbe9i1155h) From: Lu Jingchang-B35083 To: Vinod Koul CC: "djbw@fb.com" , "shawn.guo@linaro.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" Subject: RE: [PATCH 3/3] dma: Add Freescale eDMA engine driver support Thread-Topic: [PATCH 3/3] dma: Add Freescale eDMA engine driver support Thread-Index: AQHOqh42n/m/IZ+OnUOyyFvNQ0U/dpnJb5uAgAAzEbA= Date: Tue, 17 Sep 2013 08:08:46 +0000 Message-ID: References: <1378374799-16357-1-git-send-email-b35083@freescale.com> <20130917045359.GN17188@intel.com> In-Reply-To: <20130917045359.GN17188@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.193.20.98] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r8H890qJ010164 Content-Length: 773 Lines: 26 > -----Original Message----- > From: Vinod Koul [mailto:vinod.koul@intel.com] > Sent: Tuesday, September 17, 2013 12:54 PM > To: Lu Jingchang-B35083 > Cc: djbw@fb.com; shawn.guo@linaro.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; Wang > Huan-B18965 > Subject: Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support > > + case DMA_PAUSE: > > + if (fsl_chan->edesc) > > + fsl_edma_disable_request(fsl_chan); > racy here too... It only set the channel HW register, no list is handled, is lock needed here? Thanks! Best Regards, Jingchang ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?