Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752428Ab3IQKRA (ORCPT ); Tue, 17 Sep 2013 06:17:00 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:35812 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752145Ab3IQKQ6 (ORCPT ); Tue, 17 Sep 2013 06:16:58 -0400 MIME-Version: 1.0 X-Originating-IP: [86.59.245.170] In-Reply-To: <20130916232810.GG13318@ZenIV.linux.org.uk> References: <1379335925-30858-1-git-send-email-miklos@szeredi.hu> <1379335925-30858-3-git-send-email-miklos@szeredi.hu> <20130916181938.GD13318@ZenIV.linux.org.uk> <20130916195003.GE13318@ZenIV.linux.org.uk> <20130916220241.GF13318@ZenIV.linux.org.uk> <20130916232810.GG13318@ZenIV.linux.org.uk> Date: Tue, 17 Sep 2013 12:16:56 +0200 Message-ID: Subject: Re: [PATCH 02/11] 9p: fix dentry leak in v9fs_vfs_atomic_open_dotl() From: Miklos Szeredi To: Al Viro Cc: Linux-Fsdevel , Kernel Mailing List , "mszeredi@suse.cz" , Eric Van Hensbergen , "M. Mohan Kumar" , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1115 Lines: 29 On Tue, Sep 17, 2013 at 1:28 AM, Al Viro wrote: > On Mon, Sep 16, 2013 at 11:02:41PM +0100, Al Viro wrote: >> On Mon, Sep 16, 2013 at 10:09:46PM +0200, Miklos Szeredi wrote: >> >> > > I would definitely prefer EEXIST logics dealt with in fs/namei.c - if nothing >> > > else, it had been done wrong in too many instances... >> > >> > Okay. >> >> OK, so I'm taking 1, 5, 9, 10, 11, then add check to fs/namei.c:atomic_open(), >> leaving the rest of gfs2 ones for gfs2 tree... Give me a few and I'll push >> that. > > Pushed (head at d332c7). That should cover 9p and fuse as well, AFAICS. > Do you have any problems with that variant? Just one. This needs to be removed, since this condition is now explicitly allowed and later checked for: if (WARN_ON(excl && !(*opened & FILE_CREATED))) *opened |= FILE_CREATED; Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/