Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 19 Oct 2002 21:32:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 19 Oct 2002 21:32:18 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:39180 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id ; Sat, 19 Oct 2002 21:32:18 -0400 Date: Sun, 20 Oct 2002 02:38:21 +0100 From: Matthew Wilcox To: Marcus Alanen Cc: linux-kernel@vger.kernel.org Subject: Re: [patch] setup_arg_pages. ARCH_STACK_GROWSUP ?? Message-ID: <20021020023821.B5285@parcelfarce.linux.theplanet.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 534 Lines: 15 > As far as I can see, setup_arg_pages code is hosed for the > ARCH_STACK_GROWSUP case, completely wrong types... Does any arch even > use this? Yes, but kunmap is a NOP on that architecture, so nobody noticed. Patch looks good though. -- Revolutions do not require corporate support. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/