Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515Ab3IQMUR (ORCPT ); Tue, 17 Sep 2013 08:20:17 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:40918 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751912Ab3IQMUP (ORCPT ); Tue, 17 Sep 2013 08:20:15 -0400 MIME-Version: 1.0 In-Reply-To: <1378742636-11215-2-git-send-email-g.liakhovetski@gmx.de> References: <1378742636-11215-1-git-send-email-g.liakhovetski@gmx.de> <1378742636-11215-2-git-send-email-g.liakhovetski@gmx.de> Date: Tue, 17 Sep 2013 14:20:14 +0200 Message-ID: Subject: Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface From: Linus Walleij To: Guennadi Liakhovetski , Laurent Pinchart Cc: "linux-kernel@vger.kernel.org" , Magnus Damm , "linux-sh@vger.kernel.org" , Guennadi Liakhovetski Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1375 Lines: 32 On Mon, Sep 9, 2013 at 6:03 PM, Guennadi Liakhovetski wrote: > There are four I2C interfaces on r8a7790, each of them can be connected to > one of the two respective I2C controllers, e.g. interface #0 can be > configured to work with I2C0 or with IIC0. Additionally some of those > interfaces can also use one of several pin sets. Interface #3 is special, > because it can be used in automatic mode for DVFS. It only has one set > of pins available and those pins cannot be used for anything else, they > also lack the GPIO function. > > This patch uses the sh-pfc ability to configure pins, not associated with > GPIOs and adds support for I2C3 to the r8a7790 PFC set up. > > Signed-off-by: Guennadi Liakhovetski Pls CC Laurent who is main reviewer on all sh-pfc stuff. > +/* R8A7790 has 6 banks with 32 GPIOs in each = 192 GPIOs */ > +#define ROW_GROUP_A(r) ('Z' - 'A' + 1 + (r)) > +#define PIN_NUMBER(r, c) (((r) - 'A') * 16 + (c) + 200) > +#define PIN_A_NUMBER(r, c) PIN_NUMBER(ROW_GROUP_A(r), c) You add these #defines but do not use them. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/