Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753118Ab3IQNEV (ORCPT ); Tue, 17 Sep 2013 09:04:21 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:33109 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062Ab3IQNEQ (ORCPT ); Tue, 17 Sep 2013 09:04:16 -0400 Message-ID: <1379423051.2218.1.camel@ThinkPad-X230.localdomain> Subject: Re: [PATCH v2 2/3] ACPI / video: seperate backlight control and event interface From: Igor Gnatenko To: Aaron Lu Cc: linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , "Rafael J. Wysocki" , Matthew Garrett , Seth Forshee , Lee Chun-Yi , Richard Purdie , Yves-Alexis Perez , Felipe Contreras , Henrique de Moraes Holschuh , Jani Nikula Date: Tue, 17 Sep 2013 17:04:11 +0400 In-Reply-To: <1379409796-29350-3-git-send-email-aaron.lu@intel.com> References: <1379409796-29350-1-git-send-email-aaron.lu@intel.com> <1379409796-29350-3-git-send-email-aaron.lu@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.9.91 (3.9.91-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1350 Lines: 30 On Tue, 2013-09-17 at 17:23 +0800, Aaron Lu wrote: > The backlight control and event delivery functionality provided by ACPI > video module is mixed together and registered all during video device > enumeration time. As a result, the two functionality are also removed > together on module unload time or by the acpi_video_unregister function. > The two functionalities are actually independent and one may be useful > while the other one may be broken, so it is desirable to seperate the > two functionalities such that it is clear and easy to disable one > functionality without affecting the other one. > > APIs to selectively remove backlight control interface and/or event > delivery functionality can be easily added once needed. > > Signed-off-by: Aaron Lu Tested-by: Igor Gnatenko > --- > drivers/acpi/video.c | 451 ++++++++++++++++++++++++++++++--------------------- > include/acpi/video.h | 2 + > 2 files changed, 264 insertions(+), 189 deletions(-) -- Igor Gnatenko Fedora release 20 (Heisenbug) Linux 3.12.0-0.rc1.git0.1.fc20.x86_64 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/