Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753607Ab3IQSre (ORCPT ); Tue, 17 Sep 2013 14:47:34 -0400 Received: from merlin.infradead.org ([205.233.59.134]:54298 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322Ab3IQSrc (ORCPT ); Tue, 17 Sep 2013 14:47:32 -0400 Message-ID: <5238A3AD.6020201@kernel.dk> Date: Tue, 17 Sep 2013 12:47:09 -0600 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 MIME-Version: 1.0 To: Bjorn Helgaas CC: Kent Overstreet , Alexander Viro , linux-fsdevel , "linux-kernel@vger.kernel.org" , "Martin K. Petersen" , Gu Zheng Subject: Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free References: <20130529222955.10627.50429.stgit@bhelgaas-glaptop> <20130613183315.GH10979@localhost> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1961 Lines: 53 On 09/16/2013 07:40 AM, Bjorn Helgaas wrote: > On Thu, Jun 13, 2013 at 12:33 PM, Kent Overstreet > wrote: >> On Thu, Jun 13, 2013 at 12:14:54PM -0600, Bjorn Helgaas wrote: >>> On Wed, May 29, 2013 at 4:29 PM, Bjorn Helgaas wrote: >>>> This fixes a copy and paste error introduced by 9f060e2231 >>>> ("block: Convert integrity to bvec_alloc_bs()"). >>>> >>>> Found by Coverity (CID 1020654). >>>> >>>> Signed-off-by: Bjorn Helgaas >>>> --- >>>> fs/bio-integrity.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c >>>> index 8fb4291..45e944f 100644 >>>> --- a/fs/bio-integrity.c >>>> +++ b/fs/bio-integrity.c >>>> @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs) >>>> mempool_destroy(bs->bio_integrity_pool); >>>> >>>> if (bs->bvec_integrity_pool) >>>> - mempool_destroy(bs->bio_integrity_pool); >>>> + mempool_destroy(bs->bvec_integrity_pool); >>>> } >>>> EXPORT_SYMBOL(bioset_integrity_free); >>> >>> Kent, do you want to chime in on this? Looks like an obvious error to >>> me, but maybe I'm missing something and we should teach Coverity to >>> shut up about it. >> >> Sorry - no, this is definitely a bug: >> >> Acked-by: Kent Overstreet > > From my v3.12-rc1 reminder list: what's going on with this patch? > > It's been acked, Gu asked whether he could include it in some > patchset, I see a Sep 11 2013 patch from Gu upstream already > (bc5c8f078), but this patch (from May 29 2013) still hasn't gone > anywhere. Why is this so hard? Queued up. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/