Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688Ab3IQTEU (ORCPT ); Tue, 17 Sep 2013 15:04:20 -0400 Received: from mail-we0-f171.google.com ([74.125.82.171]:52020 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753490Ab3IQTET (ORCPT ); Tue, 17 Sep 2013 15:04:19 -0400 MIME-Version: 1.0 X-Originating-IP: [208.54.5.211] In-Reply-To: <5228913A.50807@kernel.dk> References: <26D762E250385C4D8E9D6EC3C8E47DC11E6FCF20@sambx4.stec-inc.ad> <26D762E250385C4D8E9D6EC3C8E47DC11E6FE729@sambx4.stec-inc.ad> <5228913A.50807@kernel.dk> Date: Tue, 17 Sep 2013 12:04:18 -0700 Message-ID: Subject: Re: [PATCH] block: Device driver for sTec's PCIe Kronos Card. From: Olof Johansson To: Jens Axboe Cc: Jeff Moyer , OS Engineering , "linux-kernel@vger.kernel.org" , Akhil Bhansali , Ramprasad Chinthekindi , Amit Phansalkar Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 43 On Thu, Sep 5, 2013 at 7:12 AM, Jens Axboe wrote: > On 09/05/2013 06:00 AM, Jeff Moyer wrote: >> OS Engineering writes: >> >>> Hi Jeff, >>> >>> Thank you for reviewing the patch. >> >> No problem. Jens, any objection to queueing this up for 3.12? > > I'll give it a look-over, but usually I'm pretty lax when it comes to > new drivers. So no, I'd be surprised if we can't queue this up for 3.12. I came across this driver because it was spewing a lot of really trivial and easy to fix compiler warnings. Silly stuff such as printing u32 with %lu. >From a quick look at the code, several things are immediately apparent: First, checkpatch says, on the currently existing file in -next: total: 3 errors, 61 warnings, 5817 lines checked Code like this looks _really_ confused: barrier(); val = readl(skdev->mem_map[1] + offset); barrier(); There are also some crazy long functions that should be refactored, such as skd_request_fn(). So, it looks like this driver needs a bunch of work before it's ready to go in. Or, maybe it's better to submit it with a TODO list for the staging tree instead? -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/