Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754009Ab3IQVYI (ORCPT ); Tue, 17 Sep 2013 17:24:08 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:60149 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753378Ab3IQVYG (ORCPT ); Tue, 17 Sep 2013 17:24:06 -0400 Date: Tue, 17 Sep 2013 22:23:59 +0100 From: Al Viro To: Miklos Szeredi Cc: Linux-Fsdevel , Kernel Mailing List , "mszeredi@suse.cz" , Eric Van Hensbergen , "M. Mohan Kumar" , stable@vger.kernel.org Subject: Re: [PATCH 02/11] 9p: fix dentry leak in v9fs_vfs_atomic_open_dotl() Message-ID: <20130917212359.GJ13318@ZenIV.linux.org.uk> References: <1379335925-30858-3-git-send-email-miklos@szeredi.hu> <20130916181938.GD13318@ZenIV.linux.org.uk> <20130916195003.GE13318@ZenIV.linux.org.uk> <20130916220241.GF13318@ZenIV.linux.org.uk> <20130916232810.GG13318@ZenIV.linux.org.uk> <20130917114404.GI13318@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 29 On Tue, Sep 17, 2013 at 05:36:49PM +0200, Miklos Szeredi wrote: > On Tue, Sep 17, 2013 at 1:44 PM, Al Viro wrote: > > On Tue, Sep 17, 2013 at 12:16:56PM +0200, Miklos Szeredi wrote: > > > >> Just one. This needs to be removed, since this condition is now > >> explicitly allowed and later checked for: > >> > >> if (WARN_ON(excl && !(*opened & FILE_CREATED))) > >> *opened |= FILE_CREATED; > > > > D'oh... Fixed and pushed. > > Okay, but moving the fsnotify_create() to after the no-open section > is wrong, I think, It's needed for the case of ->atomic_open() doing > lookup/create/no_open too. What a mess... It's actually even uglier than that - which dentry should we pass to fsnotify_create() in case where finish_no_open() has been given a non-NULL dentry other than one we had passed to ->atomic_open()? I think that version in mainline is actually broken in that respect as far as fuse is concerned, not that anybody sane could expect ...notify to work on fuse. Anyway, I've pushed what I think is a sane fix. Please, review and test - I don't have a setup for testing fsnotify on fuse. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/