Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159Ab3IQWbQ (ORCPT ); Tue, 17 Sep 2013 18:31:16 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:52274 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288Ab3IQWbO (ORCPT ); Tue, 17 Sep 2013 18:31:14 -0400 Message-ID: <5238D7D9.9010203@ti.com> Date: Tue, 17 Sep 2013 18:29:45 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Guenter Roeck CC: Eduardo Valentin , , , , , , , , , , , , , , Jean Delvare Subject: Re: [PATCH 06/16] hwmon: tmp102: expose to thermal fw via DT nodes References: <1379282563-14650-1-git-send-email-eduardo.valentin@ti.com> <1379282563-14650-7-git-send-email-eduardo.valentin@ti.com> <523643D4.30208@roeck-us.net> In-Reply-To: <523643D4.30208@roeck-us.net> X-Enigmail-Version: 1.5.2 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DRL6iNjCceenODkoGtIA3TOmsuj8cbFR2" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5189 Lines: 172 --DRL6iNjCceenODkoGtIA3TOmsuj8cbFR2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 15-09-2013 19:33, Guenter Roeck wrote: > On 09/15/2013 03:02 PM, Eduardo Valentin wrote: >> This patch adds to tmp102 temperature sensor the possibility >> to expose itself as thermal zone device, registered on the >> thermal framework. >> >> The thermal zone is built only if a device tree node >> describing a thermal zone for this sensor is present >> inside the tmp102 DT node. Otherwise, the driver behavior >> will be the same. >> >> Cc: Jean Delvare >> Cc: Guenter Roeck >> Cc: lm-sensors@lm-sensors.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Eduardo Valentin >> --- >> drivers/hwmon/tmp102.c | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> >> diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c >> index d7b47ab..e432444 100644 >> --- a/drivers/hwmon/tmp102.c >> +++ b/drivers/hwmon/tmp102.c >> @@ -27,6 +27,8 @@ >> #include >> #include >> #include >> +#include >> +#include >> >> #define DRIVER_NAME "tmp102" >> >> @@ -50,6 +52,7 @@ >> >> struct tmp102 { >> struct device *hwmon_dev; >> + struct thermal_zone_device *tz; >> struct mutex lock; >> u16 config_orig; >> unsigned long last_update; >> @@ -93,6 +96,19 @@ static struct tmp102 *tmp102_update_device(struct >> i2c_client *client) >> return tmp102; >> } >> >> +static int tmp102_read_temp(void *dev, long *temp) >> +{ >> + struct tmp102 *tmp102 =3D tmp102_update_device(to_i2c_client(dev)= ); >> + >> + if (tmp102->temp[0] < 0) >> + dev_warn(tmp102->hwmon_dev, >> + "operating in negative temp: %d\n", tmp102->temp[0]); >> + >=20 > Please drop this warning. >=20 Done for both drivers. > Guenter >=20 >> + *temp =3D tmp102->temp[0]; >> + >> + return 0; >> +} >> + >> static ssize_t tmp102_show_temp(struct device *dev, >> struct device_attribute *attr, >> char *buf) >> @@ -204,6 +220,16 @@ static int tmp102_probe(struct i2c_client *client= , >> goto fail_remove_sysfs; >> } >> >> + tmp102->tz =3D thermal_zone_of_sensor_register(&client->dev, 0, >> + &client->dev, >> + tmp102_read_temp, NULL); >> + if (IS_ERR(tmp102->tz)) { >> + dev_warn(&client->dev, >> + "Could not parse thermal data in device tree: %ld\n", >> + PTR_ERR(tmp102->tz)); >=20 > Please drop this warning. You already create error messages in > thermal_zone_of_sensor_register(). That should be sufficient. > The same applies to the lm75 patch. OK. Done for both. >=20 > As a side note, I would suggest to provide devm_ functions for > registration. > We are introducing those for hwmon registration, which enables us to re= move > most _remove functions. It would be great if we can keep it that way. >=20 Right. This side note is taken. Actually this is on my todo list for quite a while. But I believe this should not block this series, should it? I will be probably cleaning the thermal framework code after this current work is accepted at least. > On a higher level, I don't think it is a good idea to make thermal zone= s > and thermal zone data mandatory. Many systems may neither need nor want= it. >=20 Well, I agree with you. Did you see something hard required in the patch I sent. I made it so that it could continue the driver probe without thermal zones, as you requested. I will repost both patches in reply to our thread. Eduardo > Guenter >=20 >> + tmp102->tz =3D NULL; >> + } >> + >> dev_info(&client->dev, "initialized\n"); >> >> return 0; >> @@ -220,6 +246,8 @@ static int tmp102_remove(struct i2c_client *client= ) >> { >> struct tmp102 *tmp102 =3D i2c_get_clientdata(client); >> >> + /* thermal zone life cycle is not our responsibility */ >> + thermal_zone_of_sensor_unregister(&client->dev, tmp102->tz); >> hwmon_device_unregister(tmp102->hwmon_dev); >> sysfs_remove_group(&client->dev.kobj, &tmp102_attr_group); >> >> >=20 >=20 >=20 --=20 You have got to be excited about what you are doing. (L. Lamport) Eduardo Valentin --DRL6iNjCceenODkoGtIA3TOmsuj8cbFR2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlI4190ACgkQCXcVR3XQvP3GHQD7BSUEBuqajjm7XMykeo4s84gh YvCXQ3BdSnWdNxFAFzEA+gOqYkg5KhWl04akhJi7zDXBCG8PXjgLMo3SIYcrywbq =xKEY -----END PGP SIGNATURE----- --DRL6iNjCceenODkoGtIA3TOmsuj8cbFR2-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/