Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041Ab3IQWyL (ORCPT ); Tue, 17 Sep 2013 18:54:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32713 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753371Ab3IQWyK (ORCPT ); Tue, 17 Sep 2013 18:54:10 -0400 Date: Tue, 17 Sep 2013 18:54:02 -0400 From: Luiz Capitulino To: Andrew Morton Cc: Eric Paris , Konstantin Khlebnikov , linux-kernel@vger.kernel.org, oleg@redhat.com, rgb@redhat.com Subject: Re: [RFC] audit: avoid soft lockup in audit_log_start() Message-ID: <20130917185402.601e524d@redhat.com> In-Reply-To: <20130917152842.51158606ed46ec67b97b4448@linux-foundation.org> References: <20130828182114.6b67ea90@redhat.com> <522DDBED.2020505@openvz.org> <1378829005.12992.30.camel@flatline.rdu.redhat.com> <20130917152842.51158606ed46ec67b97b4448@linux-foundation.org> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2126 Lines: 52 On Tue, 17 Sep 2013 15:28:42 -0700 Andrew Morton wrote: > On Tue, 10 Sep 2013 12:03:25 -0400 Eric Paris wrote: > > > > --- a/kernel/audit.c > > > +++ b/kernel/audit.c > > > @@ -1215,9 +1215,10 @@ struct audit_buffer *audit_log_start(struct audit_context *ctx, gfp_t gfp_mask, > > > > > > sleep_time = timeout_start + audit_backlog_wait_time - > > > jiffies; > > > - if ((long)sleep_time > 0) > > > + if ((long)sleep_time > 0) { > > > wait_for_auditd(sleep_time); > > > - continue; > > > + continue; > > > + } > > > } > > > if (audit_rate_check() && printk_ratelimit()) > > > printk(KERN_WARNING > > > > I think this is the right(ish) fix, at least it gets at the real bug. > > 829199197a430dade2519d54f5545c4a094393b8 definitely is the problem. > > um, which idiot wrote that? LOL! > Thngs are somewhat foggy at present. I have two patches from > Dan/Chuck: > > Subject: audit: fix soft lockups due to loop in audit_log_start() wh,en audit_backlog_limit exceeded > Subject: audit: two efficiency fixes for audit mechanism > > and two from Luiz: > > Subject: audit: flush_hold_queue(): don't drop queued SKBs > Subject: audit: kaudit_send_skb(): make non-blocking call to netlink_unicast() > > and now a protopatch from Konstantin which eparis likes. > > So, umm, guys, can you please devote a bit of time to working out what > we should do here? You can drop my patches. Konstantin's patch is a better version of my first RFC. My second series is kind of a new concept which the audit team seems to disagree with, and I won't push hard on it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/