Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316Ab3IRPT1 (ORCPT ); Wed, 18 Sep 2013 11:19:27 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:45045 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721Ab3IRPTZ (ORCPT ); Wed, 18 Sep 2013 11:19:25 -0400 MIME-Version: 1.0 In-Reply-To: <1379335925-30858-6-git-send-email-miklos@szeredi.hu> References: <1379335925-30858-1-git-send-email-miklos@szeredi.hu> <1379335925-30858-6-git-send-email-miklos@szeredi.hu> Date: Wed, 18 Sep 2013 10:19:20 -0500 Message-ID: Subject: Re: [PATCH 05/11] cifs: fix filp leak in cifs_atomic_open() From: Steve French To: Miklos Szeredi Cc: Al Viro , linux-fsdevel , LKML , mszeredi@suse.cz, Steve French , stable@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 42 Do you want me to merge this via my tree (cifs-2.6.git) or another? On Mon, Sep 16, 2013 at 7:51 AM, Miklos Szeredi wrote: > From: Miklos Szeredi > > If an error occurs after having called finish_open() then fput() needs to > be called on the already opened file. > > Signed-off-by: Miklos Szeredi > Cc: Steve French > Cc: stable@vger.kernel.org > --- > fs/cifs/dir.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c > index d3e2eaa..5384c2a 100644 > --- a/fs/cifs/dir.c > +++ b/fs/cifs/dir.c > @@ -500,6 +500,7 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry, > if (server->ops->close) > server->ops->close(xid, tcon, &fid); > cifs_del_pending_open(&open); > + fput(file); > rc = -ENOMEM; > } > > -- > 1.8.1.4 > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/