Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753799Ab3IRUue (ORCPT ); Wed, 18 Sep 2013 16:50:34 -0400 Received: from filtteri5.pp.htv.fi ([213.243.153.188]:35850 "EHLO filtteri5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753739Ab3IRUud (ORCPT ); Wed, 18 Sep 2013 16:50:33 -0400 Date: Wed, 18 Sep 2013 23:50:25 +0300 From: Aaro Koskinen To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Matt Mackall , Herbert Xu , Tony Lindgren , Russell King , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Juha Yrjola Subject: Re: [PATCH 1/2] hwrng: OMAP3 ROM Random Number Generator support Message-ID: <20130918205025.GC30568@blackmetal.musicnaut.iki.fi> References: <201303281854.02847@pali> <1379534757-20870-1-git-send-email-pali.rohar@gmail.com> <1379534757-20870-2-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1379534757-20870-2-git-send-email-pali.rohar@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 484 Lines: 16 Hi, On Wed, Sep 18, 2013 at 10:05:56PM +0200, Pali Roh?r wrote: > + if (IS_ERR(rng_clk)) { > + printk(KERN_ERR "%s: unable to get RNG clock\n", > + omap3_rom_rng_name); > + return IS_ERR(rng_clk); This should be PTR_ERR(). A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/