Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753076Ab3ISIoB (ORCPT ); Thu, 19 Sep 2013 04:44:01 -0400 Received: from merlin.infradead.org ([205.233.59.134]:33105 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752130Ab3ISIoA (ORCPT ); Thu, 19 Sep 2013 04:44:00 -0400 Date: Thu, 19 Sep 2013 10:43:49 +0200 From: Peter Zijlstra To: eranian@gmail.com Cc: Vince Weaver , Ingo Molnar , Peter Anvin , LKML , adrian.hunter@intel.com, Thomas Gleixner , linux-tip-commits@vger.kernel.org Subject: Re: [tip:perf/core] perf: Fix broken union in ' struct perf_event_mmap_page' Message-ID: <20130919084349.GM9326@twins.programming.kicks-ass.net> References: <1372425741-1676-2-git-send-email-adrian.hunter@intel.com> <20130918085722.GL12926@twins.programming.kicks-ass.net> <20130918154224.GK9326@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 24 On Wed, Sep 18, 2013 at 08:33:53PM +0200, Stephane Eranian wrote: > On Wed, Sep 18, 2013 at 5:42 PM, Peter Zijlstra wrote: > > On Wed, Sep 18, 2013 at 10:19:32AM -0400, Vince Weaver wrote: > >> Can you point to any code that is fixed by the commit? > > > > I have some, but I don't think a lot of people use it. > > > > Would you be ok with something like the below? It should preserve > > functionality for code that only cares about cap_usr_rdpmc (PAPI). > > > > Stephane, does libpfm use any of these? > > > Yes, there is an example using this. Need to verify it is not broken > currently (self_count.c). So if that only uses cap_usr_rdpmc, you have the same issue as Vince and the proposed solutions would work for you too. If you also use cap_usr_time we've a bit of a problem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/