Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052Ab3ISJEJ (ORCPT ); Thu, 19 Sep 2013 05:04:09 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:49071 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057Ab3ISJEH (ORCPT ); Thu, 19 Sep 2013 05:04:07 -0400 Message-ID: <523ABE10.6060802@linux.vnet.ibm.com> Date: Thu, 19 Sep 2013 11:04:16 +0200 From: Peter Oberparleiter MIME-Version: 1.0 To: Frantisek Hrbata CC: linux-kernel@vger.kernel.org, jstancek@redhat.com, keescook@chromium.org, peter.oberparleiter@de.ibm.com, rusty@rustcorp.com.au, linux-arch@vger.kernel.org, arnd@arndb.de, mgahagan@redhat.com, agospoda@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH v2 2/4] gcov: add support for gcc 4.7 gcov format References: <1378305776-3644-1-git-send-email-fhrbata@redhat.com> <1378305776-3644-3-git-send-email-fhrbata@redhat.com> In-Reply-To: <1378305776-3644-3-git-send-email-fhrbata@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13091909-5024-0000-0000-000007448E56 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 43 On 04.09.2013 16:42, Frantisek Hrbata wrote: > The gcov in-memory format changed in gcc 4.7. The biggest change, which > requires this special implementation, is that gcov_info no longer contains > array of counters for each counter type for all functions and gcov_fn_info is > not used for mapping of function's counters to these arrays(offset). Now each > gcov_fn_info contans it's counters, which makes things a little bit easier. > > This is heavily based on the previous gcc_3_4.c implementation and patches > provided by Peter Oberparleiter. Specially the buffer gcda implementation for > iterator. > > v2: - removed const definition for gcov_fn_info in gcov_info > - use vmalloc for counter values in gcov_info_dup > - use iter buffer for gcda > > Signed-off-by: Frantisek Hrbata The patch is missing an include statement: CC kernel/gcov/gcc_4_7.o kernel/gcov/gcc_4_7.c: In function ‘gcov_info_dup’: kernel/gcov/gcc_4_7.c:293:4: error: implicit declaration of function ‘vmalloc’ [-Werror=implicit-function-declaration] kernel/gcov/gcc_4_7.c:293:20: warning: assignment makes pointer from integer without a cast [enabled by default] With that added, it compiles and works with gcc 4.3.4 and 4.7.2 on kernel 3.21-rc1 on s390x. --- a/kernel/gcov/gcc_4_7.c +++ b/kernel/gcov/gcc_4_7.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "gcov.h" #define GCOV_COUNTERS 8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/