Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211Ab3ISOLN (ORCPT ); Thu, 19 Sep 2013 10:11:13 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:65336 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767Ab3ISOLK (ORCPT ); Thu, 19 Sep 2013 10:11:10 -0400 Message-ID: <523B05FD.7020200@cogentembedded.com> Date: Thu, 19 Sep 2013 18:11:09 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Roger Quadros CC: balbi@ti.com, bcousson@baylibre.com, tony@atomide.com, balajitk@ti.com, kishon@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC PATCH 15/15] arm: dts: dra7: add sata node References: <1379595943-14622-1-git-send-email-rogerq@ti.com> <1379597059-15405-1-git-send-email-rogerq@ti.com> In-Reply-To: <1379597059-15405-1-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2945 Lines: 94 Hello. On 09/19/2013 05:24 PM, Roger Quadros wrote: > From: Balaji T K > Add support for sata controller. > [Roger Q] Clean up. > CC: Benoit Cousson > Signed-off-by: Balaji T K > Signed-off-by: Roger Quadros > --- > arch/arm/boot/dts/dra7.dtsi | 49 +++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 49 insertions(+), 0 deletions(-) > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index ce9a0f0..545545d 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -426,6 +426,55 @@ > dma-names = "tx", "rx"; > }; > > + omap_control_sata: control-phy@4a002374 { > + compatible = "ti,control-phy-pipe3"; > + reg = <0x4a002374 0x4>; > + reg-names = "power"; > + clocks = <&sys_clkin1>; > + clock-names = "sysclk"; > + }; > + > + ocp2scp3: ocp2scp3@4a090000 { > + compatible = "ti,omap-ocp2scp"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + ti,hwmods = "ocp2scp3"; > + reg = <0x4a090000 0x1f>; /* ocp2scp3 */ > + reg-names = "ocp2scp3"; > + sata_phy: sataphy@4A096000 { It's better to name the PHY nodes uniformly after already standard "ethernet-phy" and your "control-phy". > + compatible = "ti,phy-pipe3-sata"; > + reg = <0x4A096000 0x80>, /* phy_rx */ > + <0x4A096400 0x64>, /* phy_tx */ > + <0x4A096800 0x40>; /* pll_ctrl */ > + reg-names = "phy_rx", "phy_tx", "pll_ctrl"; > + ctrl-module = <&omap_control_sata>; > + clocks = <&sata_ref_clk>, > + <&sys_clkin1>; > + clock-names = "optclk", "sysclk"; > + #phy-cells = <0>; > + }; > + }; > + > + sata: sata@4a141100 { > + compatible = "ti,sata"; > + ti,hwmods = "sata"; > + reg = <0x4a141100 0x7>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + dwc-ahci@4a140000 { Hm, ePAPR spec. [1] says that "the name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model", so it looks like the name should be "sata" as well. I'm a bit at a loss here, not sure why you had to use the nested device nodes. > + compatible = "snps,dwc-ahci"; > + reg = <0x4a140000 0x1100>; > + interrupts = <0 54 0x4>; > + phys = <&sata_phy>; Hm, it's the third PHY related generic property I'm encountering. First, there was "phy-handle", then "phy", now "phys"... Seems like a bit too much. :-) > + phy-names = "sata-phy"; > + clocks = <&sata_ref_clk>; > + clock-names = "optclk"; > + }; > + }; [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/