Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753887Ab3ISUvi (ORCPT ); Thu, 19 Sep 2013 16:51:38 -0400 Received: from mail-ie0-f171.google.com ([209.85.223.171]:63524 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255Ab3ISUvg (ORCPT ); Thu, 19 Sep 2013 16:51:36 -0400 MIME-Version: 1.0 In-Reply-To: <4974289.QhzOmFXm0s@vostro.rjw.lan> References: <4974289.QhzOmFXm0s@vostro.rjw.lan> From: Bjorn Helgaas Date: Thu, 19 Sep 2013 14:51:15 -0600 Message-ID: Subject: Re: [PATCH] PCI / ACPI / PM: Clear pme_poll for devices in D3cold on wakeup To: "Rafael J. Wysocki" Cc: Linux PCI , ACPI Devel Maling List , LKML , Linux PM list , Huang Ying , Matthew Garrett , "David E. Box" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2294 Lines: 59 On Fri, Sep 13, 2013 at 7:38 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Commit 448bd85 (PCI/PM: add PCIe runtime D3cold support) added a > piece of code to pci_acpi_wake_dev() causing that function to behave > in a special way for devices in D3cold (so that their configuration > registeres are not accessed before those devices are resumed). s/registeres/registers/ > However, it didn't take the clearing of the pme_poll flag into > account. That has to be done for all devices, even if they are in > D3cold, or pci_pme_list_scan() will not know that wakeup has been > signaled for the device and will poll its PME Status bit > unnecessarily. > > Fix the problem by moving the clearing of the pme_poll flag in > pci_acpi_wake_dev() before the code introduced by commit 448bd85. > > Reported-and-tested-by: David E. Box > Signed-off-by: Rafael J. Wysocki Acked-by: Bjorn Helgaas > Cc: 3.6+ # 3.6+ > --- > drivers/pci/pci-acpi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Index: linux-pm/drivers/pci/pci-acpi.c > =================================================================== > --- linux-pm.orig/drivers/pci/pci-acpi.c > +++ linux-pm/drivers/pci/pci-acpi.c > @@ -47,6 +47,9 @@ static void pci_acpi_wake_dev(acpi_handl > if (event != ACPI_NOTIFY_DEVICE_WAKE || !pci_dev) > return; > > + if (pci_dev->pme_poll) > + pci_dev->pme_poll = false; > + > if (pci_dev->current_state == PCI_D3cold) { > pci_wakeup_event(pci_dev); > pm_runtime_resume(&pci_dev->dev); > @@ -57,9 +60,6 @@ static void pci_acpi_wake_dev(acpi_handl > if (pci_dev->pme_support) > pci_check_pme_status(pci_dev); > > - if (pci_dev->pme_poll) > - pci_dev->pme_poll = false; > - > pci_wakeup_event(pci_dev); > pm_runtime_resume(&pci_dev->dev); > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/