Message-ID: <1379628622.5862.5.camel@joe-AO722>
Subject: Re: [PATCH 2/10] xtensa: Cocci spatch "noderef"
From: Joe Perches <joe@perches.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org,
        linux-kernel@vger.kernel.org
Date: Thu, 19 Sep 2013 15:10:22 -0700
In-Reply-To: <1379604755851-2004428468-2-diffsplit-thomas@m3y3r.de>
References: <1379604755850-858421494-0-diffsplit-thomas@m3y3r.de>
	 <1379604755851-2004428468-2-diffsplit-thomas@m3y3r.de>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 845
Lines: 26

On Thu, 2013-09-19 at 23:42 +0200, Thomas Meyer wrote:
> sizeof when applied to a pointer typed expression gives the size of the
> pointer.

Hi Thomas, thanks for doing the series...

> diff -u -p a/arch/xtensa/platforms/iss/network.c b/arch/xtensa/platforms/iss/network.c
[]
> @@ -737,7 +737,7 @@ static int __init iss_net_setup(char *st
>  		return 1;
>  	}
>  
> -	if ((new = alloc_bootmem(sizeof new)) == NULL) {
> +	if ((new = alloc_bootmem(sizeof *new)) == NULL) {

sizeof(*new)

Please run coccinelle generated patches through checkpatch
(and the compiler of course) before submitting them.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/