Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754384Ab3ITIgi (ORCPT ); Fri, 20 Sep 2013 04:36:38 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:34779 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754353Ab3ITIgf (ORCPT ); Fri, 20 Sep 2013 04:36:35 -0400 MIME-Version: 1.0 In-Reply-To: <1378294169-22661-2-git-send-email-acourbot@nvidia.com> References: <1378294169-22661-1-git-send-email-acourbot@nvidia.com> <1378294169-22661-2-git-send-email-acourbot@nvidia.com> Date: Fri, 20 Sep 2013 10:36:34 +0200 Message-ID: Subject: Re: [RFC 1/5] gpiolib: factorize gpiod_get/set functions From: Linus Walleij To: Alexandre Courbot Cc: Arnd Bergmann , Grant Likely , Thierry Reding , Stephen Warren , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 20 On Wed, Sep 4, 2013 at 1:29 PM, Alexandre Courbot wrote: > gpiod_get/set functions share common code between their regular and > cansleep variants. The exporting of the gpiod interface will make > the situation worse. This patch factorizes the common code to avoid code > redundancy. > > Signed-off-by: Alexandre Courbot I don't see why this patch should be RFC? I just rebased and applied it, it's a clean and nice refactoring. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/