Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754281Ab3ITJWh (ORCPT ); Fri, 20 Sep 2013 05:22:37 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:33577 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148Ab3ITJWe (ORCPT ); Fri, 20 Sep 2013 05:22:34 -0400 Message-ID: <523C13BC.10400@ti.com> Date: Fri, 20 Sep 2013 12:22:04 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Sergei Shtylyov CC: , , , , , , , , , Subject: Re: [RFC PATCH 12/15] ARM: dts: omap5: add ocp2scp1 address resource References: <1379595943-14622-1-git-send-email-rogerq@ti.com> <1379597019-15294-1-git-send-email-rogerq@ti.com> <523B0782.7050501@cogentembedded.com> In-Reply-To: <523B0782.7050501@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 40 Hi, On 09/19/2013 05:17 PM, Sergei Shtylyov wrote: > On 09/19/2013 05:23 PM, Roger Quadros wrote: > >> Add OCP2SCP1 module address space. > >> CC: Benoit Cousson >> Signed-off-by: Roger Quadros >> --- >> arch/arm/boot/dts/omap5.dtsi | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi >> index 06aa665..8a88a94 100644 >> --- a/arch/arm/boot/dts/omap5.dtsi >> +++ b/arch/arm/boot/dts/omap5.dtsi >> @@ -663,6 +663,7 @@ >> #size-cells = <1>; >> ranges; >> ti,hwmods = "ocp2scp1"; >> + reg = <0x4a080000 0x1f>; > > Are you sure length is not 0x20? Actually there are just 4 of 32-bit registers with the last one starting at 0x18, so I think length should be 0x1c. I copied 0x1f from omap4.dtsi. Looks like that is wrong as well. But it is harmless as nobody else is using that address. I'll fix this to 0x1c in next rev. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/