Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752256Ab3ITOcd (ORCPT ); Fri, 20 Sep 2013 10:32:33 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:40548 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119Ab3ITOca (ORCPT ); Fri, 20 Sep 2013 10:32:30 -0400 MIME-Version: 1.0 In-Reply-To: <1379670782.5938.14.camel@x220.thuisdomein> References: <1377132262-15744-1-git-send-email-zwu.kernel@gmail.com> <1377133329.12003.9.camel@joe-AO722> <1377134271.12003.15.camel@joe-AO722> <1377181627.2009.2.camel@dabdike.int.hansenpartnership.com> <1379670782.5938.14.camel@x220.thuisdomein> Date: Fri, 20 Sep 2013 23:32:29 +0900 Message-ID: Subject: Re: [PATCH] scsi: fix the build warning From: Akinobu Mita To: Paul Bolle Cc: James Bottomley , "Martin K. Petersen" , Joe Perches , Zhi Yong Wu , "linux-scsi@vger.kernel.org" , linux-kernel mlist , Zhi Yong Wu , Douglas Gilbert , Antonio Alecrim Jr Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1987 Lines: 42 2013/9/20 Paul Bolle : > On Thu, 2013-08-22 at 23:49 +0900, Akinobu Mita wrote: >> 2013/8/22 James Bottomley : >> > On Thu, 2013-08-22 at 21:42 +0900, Akinobu Mita wrote: >> >> Unfortunately, this warning isn't fixed in linux-next, either. >> >> Paul Bolle also sent a patch that fixes the same warning in a little >> >> bit different way. >> > >> > Well, it is and it isn't. Whether you see the warning seems to depend >> > on how gcc was built. My take is that an impossible default case just >> > to keep some versions of gcc quiet is a bit pointless. >> >> As Joe said in the other reply, scsi_debug_guard could be a negative >> value (scsi_debug_guard > 1 is only prohibited). So this warning >> does not seem a false positive. > > I too think that GCC is correct here. Perhaps the people not seeing this > warning don't have CONFIG_SCSI_DEBUG set. > > A week ago Antonia also submitted a patch to silence this warning > ( https://lkml.org/lkml/2013/9/13/649 ). That's at least the third time > someone tried to silence it since it got introduced in the v3.11 cycle. > > Akinobu, could you please say how you'd like this warning to be > silenced? Or is an actual fix queued somewhere? Yesterday, I sent a patch set which includes two fixes for this issue. I wish this to be merged and I'll do my best. http://marc.info/?l=linux-scsi&m=137950732530325&w=2 http://marc.info/?l=linux-scsi&m=137950732530326&w=2 The first one prevents scsi_debug_guard from being a negative value by changing the type of scsi_debug_guard to 'unsigned int'. The second one is actually titled sparse warning fix, but it also silences this GCC warning by chaning from switch statement to if/else statements. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/