Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710Ab3ITQIz (ORCPT ); Fri, 20 Sep 2013 12:08:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271Ab3ITQIy (ORCPT ); Fri, 20 Sep 2013 12:08:54 -0400 Message-ID: <1379693326.5434.11.camel@flatline.rdu.redhat.com> Subject: Re: [PATCH] audit: remove newline accidentally added during session id helper refactor From: Eric Paris To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, Steve Grubb Date: Fri, 20 Sep 2013 12:08:46 -0400 In-Reply-To: <0c842120dc69b8dadc143ee70c29094e1f9d5110.1379517385.git.rgb@redhat.com> References: <0c842120dc69b8dadc143ee70c29094e1f9d5110.1379517385.git.rgb@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1243 Lines: 33 On Wed, 2013-09-18 at 11:17 -0400, Richard Guy Briggs wrote: > A newline was accidentally added during session ID helper refactorization in > commit 4d3fb709. This needlessly uses up buffer space, messes up syslog > formatting and makes userspace processing less efficient. Remove it. > > Signed-off-by: Richard Guy Briggs Acked-by: Eric Paris > --- > kernel/audit.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 3d17670..ac16540 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1413,7 +1413,7 @@ void audit_log_session_info(struct audit_buffer *ab) > u32 sessionid = audit_get_sessionid(current); > uid_t auid = from_kuid(&init_user_ns, audit_get_loginuid(current)); > > - audit_log_format(ab, " auid=%u ses=%u\n", auid, sessionid); > + audit_log_format(ab, " auid=%u ses=%u", auid, sessionid); > } > > void audit_log_key(struct audit_buffer *ab, char *key) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/