Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909Ab3ITQTG (ORCPT ); Fri, 20 Sep 2013 12:19:06 -0400 Received: from mail-we0-f179.google.com ([74.125.82.179]:57414 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674Ab3ITQTD (ORCPT ); Fri, 20 Sep 2013 12:19:03 -0400 MIME-Version: 1.0 X-Originating-IP: [173.13.129.225] In-Reply-To: <1379693332-10585-1-git-send-email-nm@ti.com> References: <1379693332-10585-1-git-send-email-nm@ti.com> Date: Fri, 20 Sep 2013 09:19:02 -0700 Message-ID: Subject: Re: [RFC PATCH] ARM: OMAP3630: Add generic machine descriptor From: Olof Johansson To: Nishanth Menon Cc: Tony Lindgren , =?ISO-8859-1?Q?Beno=EEt_Cousson?= , "linux-arm-kernel@lists.infradead.org" , linux-omap , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 19 Hi, On Fri, Sep 20, 2013 at 9:08 AM, Nishanth Menon wrote: > An alternative approach may be to (for all SoCs): > 1. define every SoC entry - ti,omap3430 ti,omap3630... > 2. have a generic omap3_init which uses "if (of_machine_is_compatible("ti,omap3630"))" > to invoke the appropriate omap3xxx_init_early. Yes, this would be better, but you can do add a DT_MACHINE as in this patch but have ti,omap3630 as the dt_compat table. Then there's no need to add runtime checks. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/