Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722Ab3ITQro (ORCPT ); Fri, 20 Sep 2013 12:47:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34139 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281Ab3ITQrn (ORCPT ); Fri, 20 Sep 2013 12:47:43 -0400 Date: Fri, 20 Sep 2013 12:47:32 -0400 From: Dave Jones To: rostedt@goodmis.org Cc: Linux Kernel Subject: tracing: don't stuff stale pointers in filp->private_data Message-ID: <20130920164732.GA31520@redhat.com> Mail-Followup-To: Dave Jones , rostedt@goodmis.org, Linux Kernel MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 21 Probably harmless, but still not a nice thing to do. Signed-off-by: Dave Jones diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 368a4d5..75d3556 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode, struct file *filp) if (ret < 0) { trace_array_put(tr); kfree(dir); + dir = NULL; } filp->private_data = dir; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/