Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208Ab3ITRQu (ORCPT ); Fri, 20 Sep 2013 13:16:50 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:46842 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752950Ab3ITRQt (ORCPT ); Fri, 20 Sep 2013 13:16:49 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:1b02:6e3b:e5ff:fe16:f1aa] In-Reply-To: <20130920162329.GC18721@radagast> References: <1379693332-10585-1-git-send-email-nm@ti.com> <20130920162329.GC18721@radagast> Date: Fri, 20 Sep 2013 10:16:48 -0700 Message-ID: Subject: Re: [RFC PATCH] ARM: OMAP3630: Add generic machine descriptor From: Olof Johansson To: Felipe Balbi Cc: Nishanth Menon , Tony Lindgren , =?ISO-8859-1?Q?Beno=EEt_Cousson?= , "linux-arm-kernel@lists.infradead.org" , linux-omap , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1291 Lines: 30 On Fri, Sep 20, 2013 at 9:23 AM, Felipe Balbi wrote: > Hi, > > On Fri, Sep 20, 2013 at 09:19:02AM -0700, Olof Johansson wrote: >> On Fri, Sep 20, 2013 at 9:08 AM, Nishanth Menon wrote: >> > An alternative approach may be to (for all SoCs): >> > 1. define every SoC entry - ti,omap3430 ti,omap3630... >> > 2. have a generic omap3_init which uses "if (of_machine_is_compatible("ti,omap3630"))" >> > to invoke the appropriate omap3xxx_init_early. >> >> Yes, this would be better, but you can do add a DT_MACHINE as in this >> patch but have ti,omap3630 as the dt_compat table. Then there's no >> need to add runtime checks. > > I was going to reply that adding of_machine_is_compatible("ti,omap3630") > would help in some situations, but guess it's already tainted ;-) Oh, if it's just a few checks, then by all means go down that route. I didn't look at the code to see how much it would be. But if a new DT_MACHINE is added, then it should definitely be based on ti,omap3630 instead of listing all the boards. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/