Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sun, 20 Oct 2002 15:30:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sun, 20 Oct 2002 15:30:49 -0400 Received: from outpost.ds9a.nl ([213.244.168.210]:34520 "EHLO outpost.ds9a.nl") by vger.kernel.org with ESMTP id ; Sun, 20 Oct 2002 15:30:47 -0400 Date: Sun, 20 Oct 2002 21:36:52 +0200 From: bert hubert To: Rasmus Andersen Cc: linux-kernel@vger.kernel.org Subject: Re: Error in get_swap_page? (2.5.44) Message-ID: <20021020193652.GC26384@outpost.ds9a.nl> Mail-Followup-To: bert hubert , Rasmus Andersen , linux-kernel@vger.kernel.org References: <20021020213217.A17457@jaquet.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021020213217.A17457@jaquet.dk> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 20 On Sun, Oct 20, 2002 at 09:32:17PM +0200, Rasmus Andersen wrote: > Unless I am mistaken, we return stuff (entry) from the local > stack in swapfile.c::get_swap_page. Am I mistaken? Yes. This just returns a struct by value over the stack, which is frowned upon in some circles, but is not an error per se. Regards, bert -- http://www.PowerDNS.com Versatile DNS Software & Services http://lartc.org Linux Advanced Routing & Traffic Control HOWTO - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/