Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754684Ab3ITVAG (ORCPT ); Fri, 20 Sep 2013 17:00:06 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:45461 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754170Ab3ITVAC (ORCPT ); Fri, 20 Sep 2013 17:00:02 -0400 MIME-Version: 1.0 In-Reply-To: <20130920203222.GA14306@kroah.com> References: <1379705547-15028-1-git-send-email-kys@microsoft.com> <20130920203222.GA14306@kroah.com> Date: Fri, 20 Sep 2013 17:00:00 -0400 Message-ID: Subject: Re: Drivers: scsi: FLUSH timeout From: Laurence Oberman To: Greg KH Cc: "K. Y. Srinivasan" , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, jbottomley@parallels.com, hch@infradead.org, linux-scsi@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 28 I am thinking Srini meant in the sd_mod driver module. #define SD_FLUSH_TIMEOUT (60 * HZ) Laurence On Fri, Sep 20, 2013 at 4:32 PM, Greg KH wrote: > On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: >> The SD_FLUSH_TIMEOUT value is currently hardcoded. > > Hardcoded where? Please, more context. > >> On our cloud, we sometimes hit this timeout. I was wondering if we >> could make this a module parameter. If this is acceptable, I can send >> you a patch for this. > > A module parameter don't make sense for a per-device value, does it? > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/