Message-ID: <1379733640.5488.3.camel@marge.simpson.net>
Subject: Re: Null pointer deference in drivers/power/pm2301_charger.c
From: Mike Galbraith <bitbucket@online.de>
To: Valentin Ilie <eminemix@gmail.com>
Cc: anton@enomsg.org, dwmw2@infradead.org, linux-kernel@vger.kernel.org
Date: Sat, 21 Sep 2013 05:20:40 +0200
In-Reply-To: <CAHuBVBb7B9UPiqZH0Y2MpMkUri02ApRMZfAwCctKG-tYnkbkSQ@mail.gmail.com>
References: <CAHuBVBb7B9UPiqZH0Y2MpMkUri02ApRMZfAwCctKG-tYnkbkSQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1111
Lines: 30

On Sat, 2013-09-21 at 04:25 +0300, Valentin Ilie wrote: 
> Hello,
> 
> I am trying to solve a NULL pointer deference in
> drivers/power/pm2301_charger.c (and to submit a trivial patch) but I
> am not sure how to do it.
> 
> Line 958 - 961
> pm2 = (struct pm2xxx_charger*)i2c_get_clientdata(pm2xxx_i2c_client);
>         if (!pm2) {
>                 dev_err(pm2->dev, "no pm2xxx_charger data supplied\n");
> 
> Line 976 - 978
> pm2 = (struct pm2xxx_charger*)i2c_get_clientdata(pm2xxx_i2c_client);
>         if (!pm2) {
>                 dev_err(pm2->dev, "no pm2xxx_charger data supplied\n");
> 
> As it can be clearly seen, pm2 is used with NULL value in dev_err. The
> question is, how to fix this? Should I delete the dev_err line or can
> I use printk (to avoid the need of a dev) ?

Looking below that, seems they perhaps meant &pm2xxx_i2c_client->dev.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/