Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424Ab3IUOc7 (ORCPT ); Sat, 21 Sep 2013 10:32:59 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:43292 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103Ab3IUOc6 (ORCPT ); Sat, 21 Sep 2013 10:32:58 -0400 Date: Sat, 21 Sep 2013 15:32:55 +0100 From: Al Viro To: Dave Jones , rostedt@goodmis.org, Linux Kernel Subject: Re: tracing: don't stuff stale pointers in filp->private_data Message-ID: <20130921143255.GS13318@ZenIV.linux.org.uk> References: <20130920164732.GA31520@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130920164732.GA31520@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 24 On Fri, Sep 20, 2013 at 12:47:32PM -0400, Dave Jones wrote: > Probably harmless, but still not a nice thing to do. > > Signed-off-by: Dave Jones > > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c > index 368a4d5..75d3556 100644 > --- a/kernel/trace/trace_events.c > +++ b/kernel/trace/trace_events.c > @@ -1124,6 +1124,7 @@ static int system_tr_open(struct inode *inode, struct file *filp) > if (ret < 0) { > trace_array_put(tr); > kfree(dir); > + dir = NULL; > } > > filp->private_data = dir; Er... Why not simply return ret; instead? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/