Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543Ab3IUUBi (ORCPT ); Sat, 21 Sep 2013 16:01:38 -0400 Received: from merlin.infradead.org ([205.233.59.134]:53137 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799Ab3IUUBg (ORCPT ); Sat, 21 Sep 2013 16:01:36 -0400 Date: Sat, 21 Sep 2013 14:01:32 -0600 From: Jens Axboe To: Andrew Morton Cc: Olof Johansson , Jeff Moyer , OS Engineering , "linux-kernel@vger.kernel.org" , Akhil Bhansali , Ramprasad Chinthekindi , Amit Phansalkar Subject: Re: [PATCH] block: Device driver for sTec's PCIe Kronos Card. Message-ID: <20130921200132.GF2312@kernel.dk> References: <26D762E250385C4D8E9D6EC3C8E47DC11E6FCF20@sambx4.stec-inc.ad> <26D762E250385C4D8E9D6EC3C8E47DC11E6FE729@sambx4.stec-inc.ad> <5228913A.50807@kernel.dk> <5238B9A7.6040002@kernel.dk> <20130920153128.63244ec2658b7ad3aee0e2e4@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130920153128.63244ec2658b7ad3aee0e2e4@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 24 On Fri, Sep 20 2013, Andrew Morton wrote: > On Tue, 17 Sep 2013 14:20:55 -0600 Jens Axboe wrote: > > > > So, it looks like this driver needs a bunch of work before it's ready > > > to go in. Or, maybe it's better to submit it with a TODO list for the > > > staging tree instead? > > > > Not disagreeing with you, it definitely needs a bit of cleaning. And so > > far stec has not been very responsive in fixing those issues. > > Geeze. Here's what I came up with, mainly to make i386 compile: Thanks Andrew. It's not the fixes themselves that are tricky, I would just have liked a little more proof that the submission wasn't just a dump'n run. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/