Message-ID: <523EB423.7090900@intel.com>
Date: Sun, 22 Sep 2013 17:10:59 +0800
From: Aaron Lu <aaron.lu@intel.com>
MIME-Version: 1.0
To: Igor Gnatenko <i.gnatenko.brain@gmail.com>
CC: linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Daniel Vetter <daniel@ffwll.ch>, "Rafael J. Wysocki" <rjw@sisk.pl>,
        Matthew Garrett <matthew.garrett@nebula.com>,
        Seth Forshee <seth.forshee@canonical.com>,
        Lee Chun-Yi <joeyli.kernel@gmail.com>,
        Richard Purdie <rpurdie@rpsys.net>,
        Yves-Alexis Perez <corsac@debian.org>,
        Felipe Contreras <felipe.contreras@gmail.com>,
        Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
        Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2 0/3] Fix Win8 backlight issue
References: <1379409796-29350-1-git-send-email-aaron.lu@intel.com>   <1379424853.3348.1.camel@ThinkPad-X230.localdomain>   <5238FBF5.8080405@intel.com>  <1379485819.2294.1.camel@ThinkPad-X230.localdomain>  <52399D0B.3010909@intel.com> <1379507774.2294.21.camel@ThinkPad-X230.localdomain>
In-Reply-To: <1379507774.2294.21.camel@ThinkPad-X230.localdomain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1591
Lines: 40

On 09/18/2013 08:36 PM, Igor Gnatenko wrote:
> On Wed, 2013-09-18 at 20:31 +0800, Aaron Lu wrote:
>> On 09/18/2013 02:30 PM, Igor Gnatenko wrote:
>>> On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote:
>>>> On 09/17/2013 09:34 PM, Igor Gnatenko wrote:
>>>>>
>>>>> Aaron, how about fix indicator on ThinkPads ?
>>>>
>>>> Can you please describe the problem in detail, is it that when you
>>>> adjust brightness level through hotkey, there is no GUI indication?
>>>> Thanks.
>>>>
>>>> -Aaron
>>>
>>> Yes. On my ThinkPad X230 I pressing backlight hotkeys. Actually
>>> brightnes changing, but have no indicator in GUI.
>>
>> Oh, that's still the problem of _BCL not getting executed once for
>> Lenovo thinkpad laptops. I borrowed a Thinkpad X1 this afternoon and can
>> reproduce this, I'll take a look at this issue. The thinkpad-acpi module
>> already has a call to _BCL but somehow that doesn't happen.
>>
>> Since it's national holidays here, I'll check this issue when I got back
>> to work on this Saturday. Thanks for the quick test :-)
> Thanks. No problem ;-)

Here is a quick fix for thinkpad-acpi.c:
https://github.com/aaronlu/linux acpi_video_win8
commit thinkpad-acpi: fix handle locate for video and query of _BCL.

Note that it is a separate issue specifically for thinkpad so I'll
submit that patch in another thread.

Thanks,
Aaron
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/