Message-ID: <1379844021.5598.8.camel@marge.simpson.net>
Subject: Re: [PATCH] ipc/sem.c: fix update sem_otime when calling sem_op in
 semaphore initialization
From: Mike Galbraith <bitbucket@online.de>
To: Jia He <jiakernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <davidlohr.bueso@hp.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Rik van Riel <riel@redhat.com>,
        Manfred Spraul <manfred@colorfullife.com>,
        Al Viro <viro@zeniv.linux.org.uk>
Date: Sun, 22 Sep 2013 12:00:21 +0200
In-Reply-To: <523EB997.9090107@gmail.com>
References: <1379815884-11035-1-git-send-email-jiakernel@gmail.com>
	 <1379837823.5499.34.camel@marge.simpson.net>
	 <1379838364.5499.39.camel@marge.simpson.net> <523EB997.9090107@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 852
Lines: 20

On Sun, 2013-09-22 at 17:34 +0800, Jia He wrote: 
> Thanks for the comments, but pls add my email as "from jiakernel@gmail.com"
> if you have a better implementation.U know, it is my first kernel patch, maybe
> will give me a brilliant memory in the future :)

You can have the blame if you like :)

> Anyway, your implementation looks not correct to me. Because from "man semop"
> sem_otime will record the last sem operation time of semop. If you change the
> otime in semget(), it changes the meanings in stardard, doesn't it?

A Linux kernel doing a semop in 1970 would be a kinda neat trick :)

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/