Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752999Ab3IVLQU (ORCPT ); Sun, 22 Sep 2013 07:16:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7598 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387Ab3IVLQT (ORCPT ); Sun, 22 Sep 2013 07:16:19 -0400 Date: Sun, 22 Sep 2013 13:15:59 +0200 From: Jiri Olsa To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Namhyung Kim , LKML , Linus Torvalds , Frederic Weisbecker Subject: Re: [PATCH 1/3] perf callchain: Convert children list to rbtree Message-ID: <20130922111559.GC1036@krava.brq.redhat.com> References: <1378801458-2515-1-git-send-email-namhyung@kernel.org> <1378801458-2515-2-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1378801458-2515-2-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 38 On Tue, Sep 10, 2013 at 05:24:16PM +0900, Namhyung Kim wrote: > From: Namhyung Kim SNIP > index 2b585bc308cf..1b22b6269213 100644 > --- a/tools/perf/util/callchain.h > +++ b/tools/perf/util/callchain.h > @@ -21,10 +21,9 @@ enum chain_order { > > struct callchain_node { > struct callchain_node *parent; > - struct list_head siblings; > - struct list_head children; > struct list_head val; > struct rb_node rb_node; /* to sort nodes in an rbtree */ > + struct rb_root rb_root_in; /* sorted tree of children */ > struct rb_root rb_root; /* sorted tree of children */ > unsigned int val_nr; > u64 hit; > @@ -86,8 +85,6 @@ extern __thread struct callchain_cursor callchain_cursor; > > static inline void callchain_init(struct callchain_root *root) > { > - INIT_LIST_HEAD(&root->node.siblings); > - INIT_LIST_HEAD(&root->node.children); > INIT_LIST_HEAD(&root->node.val); don't we miss rb_root_in init here, like: root->node.rb_root_in = RB_ROOT; jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/