Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752936Ab3IVSYo (ORCPT ); Sun, 22 Sep 2013 14:24:44 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:56393 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330Ab3IVSYk (ORCPT ); Sun, 22 Sep 2013 14:24:40 -0400 Message-ID: <523F35E4.6050707@cogentembedded.com> Date: Sun, 22 Sep 2013 22:24:36 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Tejun Heo CC: Roger Quadros , balbi@ti.com, bcousson@baylibre.com, tony@atomide.com, balajitk@ti.com, kishon@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY References: <1379595943-14622-1-git-send-email-rogerq@ti.com> <1379595943-14622-9-git-send-email-rogerq@ti.com> <20130922165817.GD30946@htj.dyndns.org> In-Reply-To: <20130922165817.GD30946@htj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 34 Hello. On 09/22/2013 08:58 PM, Tejun Heo wrote: >> From: Balaji T K >> Some platforms have a PHY hooked up to the >> SATA controller. The PHY needs to be initialized >> and powered up for SATA to work. We do that >> using the PHY framework. >> [Roger Q] Cleaned up. >> CC: Tejun Heo >> Signed-off-by: Balaji T K >> Signed-off-by: Roger Quadros > Looks okay to me although I don't know whether everyone using > ahci_platform would be happy with requiring phy. Sergei, does this > look good to you? Not sure why you asked -- I'm not using this driver, neither I'm the author of it (former MV's Anton Vorontsov is IIRC). I've commented on the patch anyway though... > Thanks. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/