Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902Ab3IWAXu (ORCPT ); Sun, 22 Sep 2013 20:23:50 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:51373 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752354Ab3IWAXb (ORCPT ); Sun, 22 Sep 2013 20:23:31 -0400 MIME-Version: 1.0 In-Reply-To: <20130922225809.GL856@cmpxchg.org> References: <1379873866-29219-1-git-send-email-felipensp@gmail.com> <20130922225809.GL856@cmpxchg.org> From: Felipe Pena Date: Sun, 22 Sep 2013 21:23:09 -0300 Message-ID: Subject: Re: [PATCH 1/1] arch/parisc: mm: fix uninitialized variable usage To: Johannes Weiner Cc: "James E.J. Bottomley" , linux-parisc@vger.kernel.org, Michal Hocko , linux-kernel@vger.kernel.org, Kautuk Consul , Andrew Morton , Helge Deller Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1718 Lines: 52 Hello Johannes, On Sun, Sep 22, 2013 at 7:58 PM, Johannes Weiner wrote: > Hello Felipe, > > On Sun, Sep 22, 2013 at 03:17:46PM -0300, Felipe Pena wrote: >> The FAULT_FLAG_WRITE flag has been set based on uninitialized variable > > Oops, you are right. > >> Signed-off-by: Felipe Pena >> --- >> arch/parisc/mm/fault.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/arch/parisc/mm/fault.c b/arch/parisc/mm/fault.c >> index d10d27a..6b38026 100644 >> --- a/arch/parisc/mm/fault.c >> +++ b/arch/parisc/mm/fault.c >> @@ -182,8 +182,6 @@ void do_page_fault(struct pt_regs *regs, unsigned long code, >> >> if (user_mode(regs)) >> flags |= FAULT_FLAG_USER; >> - if (acc_type & VM_WRITE) >> - flags |= FAULT_FLAG_WRITE; >> retry: >> down_read(&mm->mmap_sem); >> vma = find_vma_prev(mm, address, &prev_vma); >> @@ -201,6 +199,9 @@ good_area: >> if ((vma->vm_flags & acc_type) != acc_type) >> goto bad_area; >> >> + if (acc_type & VM_WRITE) >> + flags |= FAULT_FLAG_WRITE; > > Can acc_type actually change between between the first round and a > retry? Otherwise, it might make sense to pull this up and place it > next to the flag initialization instead of pulling one flag down. >From what I've analyzed, this make sense. I'll make the suggested changes and send another patch. Thanks. -- Regards, Felipe Pena -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/