Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753399Ab3IWIuK (ORCPT ); Mon, 23 Sep 2013 04:50:10 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:59490 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638Ab3IWIuI (ORCPT ); Mon, 23 Sep 2013 04:50:08 -0400 MIME-Version: 1.0 In-Reply-To: References: <1378742636-11215-1-git-send-email-g.liakhovetski@gmx.de> <1378742636-11215-2-git-send-email-g.liakhovetski@gmx.de> Date: Mon, 23 Sep 2013 10:50:07 +0200 Message-ID: Subject: Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface From: Linus Walleij To: Guennadi Liakhovetski Cc: Laurent Pinchart , "linux-kernel@vger.kernel.org" , Magnus Damm , "linux-sh@vger.kernel.org" , Guennadi Liakhovetski Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 24 On Tue, Sep 17, 2013 at 7:10 PM, Guennadi Liakhovetski wrote: > On Tue, 17 Sep 2013, Linus Walleij wrote: >> > +/* R8A7790 has 6 banks with 32 GPIOs in each = 192 GPIOs */ >> > +#define ROW_GROUP_A(r) ('Z' - 'A' + 1 + (r)) >> > +#define PIN_NUMBER(r, c) (((r) - 'A') * 16 + (c) + 200) >> > +#define PIN_A_NUMBER(r, c) PIN_NUMBER(ROW_GROUP_A(r), c) >> >> You add these #defines but do not use them. > > ehm, actually I do: Argh I was just wrong, forget about this. Woudl really like Laurent's ACK on this before I apply it though. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/