Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753918Ab3IWKQN (ORCPT ); Mon, 23 Sep 2013 06:16:13 -0400 Received: from mga02.intel.com ([134.134.136.20]:44193 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753406Ab3IWKQK (ORCPT ); Mon, 23 Sep 2013 06:16:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,961,1371106800"; d="scan'208";a="407606146" Date: Mon, 23 Sep 2013 13:21:35 +0300 From: Mika Westerberg To: Linus Walleij Cc: Alexandre Courbot , "Rafael J. Wysocki" , Mathias Nyman , Arnd Bergmann , Grant Likely , Thierry Reding , Stephen Warren , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [RFC 0/5] New descriptor-based GPIO interface Message-ID: <20130923102134.GB28875@intel.com> References: <1378294169-22661-1-git-send-email-acourbot@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1610 Lines: 38 On Fri, Sep 20, 2013 at 08:06:00PM +0200, Linus Walleij wrote: > On Wed, Sep 4, 2013 at 1:29 PM, Alexandre Courbot wrote: > > > Here is a first RFC for the new GPIO interface. > > I'm quite happy with this, and given that all DT-implementations will start > to use it from day 1 I'll happily merge it when you think it's tested enough. > > On my wishlist is to also switch over the ACPI GPIO driver: > drivers/gpio/gpiolib-acpi.c to use the descriptors directly, so > I'd like one of the ACPI folks to have a look at this patch set > and see how it looks from their angle. > > Mika, Rafael, Mathias, and either of you guys have a look > at this? Apart from the con_id thing I commented, I don't see huge problems converting the ACPI GPIO helpers to this new interface. One thing that is special to ACPI is that we have two kind of GPIO "connections": GpioIo - a normal GPIO that the driver can toggle or read values GpioInt - this is specifically used as a GPIO interrupt The drivers should be able to distinguish between the two. Currently we have an extra parameter in acpi_get_gpio_by_index(..., &info) that can be used for this. However, with the new gpiod_get() I'm not sure how we are supposed to do this now? Anyway, that shouldn't prevent merging this patch set. I'm sure that we can come up with some working solution :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/