Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753962Ab3IWMGM (ORCPT ); Mon, 23 Sep 2013 08:06:12 -0400 Received: from mga14.intel.com ([143.182.124.37]:59137 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753789Ab3IWMGJ (ORCPT ); Mon, 23 Sep 2013 08:06:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.90,962,1371106800"; d="scan'208";a="298196452" From: "Kirill A. Shutemov" To: Andrea Arcangeli , Andrew Morton Cc: Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , Dave Hansen , Ning Qu , Alexander Shishkin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: [PATCHv6 11/22] thp, mm: warn if we try to use replace_page_cache_page() with THP Date: Mon, 23 Sep 2013 15:05:39 +0300 Message-Id: <1379937950-8411-12-git-send-email-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 1.8.4.rc3 In-Reply-To: <1379937950-8411-1-git-send-email-kirill.shutemov@linux.intel.com> References: <1379937950-8411-1-git-send-email-kirill.shutemov@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1078 Lines: 34 replace_page_cache_page() is only used by FUSE. It's unlikely that we will support THP in FUSE page cache any soon. Let's pospone implemetation of THP handling in replace_page_cache_page() until any will use it. -EINVAL and WARN_ONCE() for now. Signed-off-by: Kirill A. Shutemov --- mm/filemap.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/filemap.c b/mm/filemap.c index 60478ebeda..3421bcaed4 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -417,6 +417,10 @@ int replace_page_cache_page(struct page *old, struct page *new, gfp_t gfp_mask) { int error; + if (WARN_ONCE(PageTransHuge(old) || PageTransHuge(new), + "unexpected transhuge page\n")) + return -EINVAL; + VM_BUG_ON(!PageLocked(old)); VM_BUG_ON(!PageLocked(new)); VM_BUG_ON(new->mapping); -- 1.8.4.rc3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/