Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753727Ab3IWN7p (ORCPT ); Mon, 23 Sep 2013 09:59:45 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:46580 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493Ab3IWN7m (ORCPT ); Mon, 23 Sep 2013 09:59:42 -0400 Message-ID: <5240492D.6060204@ti.com> Date: Mon, 23 Sep 2013 16:59:09 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Sergei Shtylyov CC: Tejun Heo , , , , , , , , , , Subject: Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY References: <1379595943-14622-1-git-send-email-rogerq@ti.com> <1379595943-14622-9-git-send-email-rogerq@ti.com> <20130922165817.GD30946@htj.dyndns.org> <523F35E4.6050707@cogentembedded.com> <20130922215107.GD27616@mtj.dyndns.org> <523FEFC2.801@ti.com> <52403B4F.3070406@cogentembedded.com> In-Reply-To: <52403B4F.3070406@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 25 On 09/23/2013 03:59 PM, Sergei Shtylyov wrote: > Hello. > > On 23-09-2013 11:37, Roger Quadros wrote: > >>>> Not sure why you asked -- I'm not using this driver, neither I'm > >>> Well, you have better grip of what's going on in the embedded world >>> than me. I'm mostly curious whether adding dependency on PHY is okay. > >> There is no hard dependency on presence of PHY. The driver will continue >> as usual if devm_phy_get() fails. >> I hope selecting GENERIC_PHY in Kconfig is not an issue. > > Selecting in the AHCI_PLATFORM section? It seems I have overlooked it. No, I don't think it's a good idea. The generic PHY functions seem to be stubbed when GENERIC_PHY=n. > OK I will remove the select then. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/