Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976Ab3IWOEw (ORCPT ); Mon, 23 Sep 2013 10:04:52 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:60829 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753669Ab3IWOEu (ORCPT ); Mon, 23 Sep 2013 10:04:50 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130923090100.GE6192@mwanda> Date: Mon, 23 Sep 2013 16:04:50 +0200 X-Google-Sender-Auth: eJJAQBSGt10yud1NhvxJ6p9iDho Message-ID: Subject: Re: checkpatch guide for newbies From: Geert Uytterhoeven To: Peter Senna Tschudin Cc: Dan Carpenter , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1447 Lines: 35 On Mon, Sep 23, 2013 at 2:46 PM, Peter Senna Tschudin wrote: >> Ask yourself, is the warning message is clear? Is it needed? Could a s/is clear/clear/ >> It's preferred if the operator goes at the end of the first line instead of at >> the start of the second line: >> Bad: >> - PowerData = (1 << 31) | (0 << 30) | (24 << 24) >> - | BitReverse(w89rf242_txvga_data[i][0], 24); >> Good: >> + PowerData = (1 << 31) | (0 << 30) | (24 << 24) | >> + BitReverse(w89rf242_txvga_data[i][0], 24); > What is the rule for where to start the second line here? Either aligned to the equivalent part on the previous line (i.e. "BitReverse" is aligned with "(1 << 31)"), or one indent step more than the beginning of the first line (i.e. "BitReverse" is indented by one more TAB tjan "PowerData"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/