Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019Ab3IWOM4 (ORCPT ); Mon, 23 Sep 2013 10:12:56 -0400 Received: from mail-ye0-f178.google.com ([209.85.213.178]:58370 "EHLO mail-ye0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753584Ab3IWOMy (ORCPT ); Mon, 23 Sep 2013 10:12:54 -0400 Date: Mon, 23 Sep 2013 10:12:51 -0400 From: Tejun Heo To: Sergei Shtylyov Cc: Roger Quadros , balbi@ti.com, bcousson@baylibre.com, tony@atomide.com, balajitk@ti.com, kishon@ti.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY Message-ID: <20130923141251.GB13844@htj.dyndns.org> References: <1379595943-14622-1-git-send-email-rogerq@ti.com> <1379595943-14622-9-git-send-email-rogerq@ti.com> <523F3567.80303@cogentembedded.com> <20130922214859.GC27616@mtj.dyndns.org> <52404BD6.9070101@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52404BD6.9070101@cogentembedded.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 17 On Mon, Sep 23, 2013 at 06:10:30PM +0400, Sergei Shtylyov wrote: > >Unless it's actually likely to cause inclusion loop, I think it's > >better to include the header than adding explicit declarations. > > Apparently, tastes differ here. E.g. Greg KH would have also told > Roger to use forward declaration in such case. :-) Yes, it's a matter of taste, but, of course mine is better than Greg's. :P -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/