Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123Ab3IWTOd (ORCPT ); Mon, 23 Sep 2013 15:14:33 -0400 Received: from mail-ie0-f176.google.com ([209.85.223.176]:37386 "EHLO mail-ie0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752216Ab3IWTOa (ORCPT ); Mon, 23 Sep 2013 15:14:30 -0400 MIME-Version: 1.0 In-Reply-To: <1379320326-13241-3-git-send-email-treding@nvidia.com> References: <1379320326-13241-1-git-send-email-treding@nvidia.com> <1379320326-13241-3-git-send-email-treding@nvidia.com> Date: Mon, 23 Sep 2013 21:14:30 +0200 Message-ID: Subject: Re: [PATCH 2/9] irqdomain: Introduce __irq_create_mapping() From: Linus Walleij To: Thierry Reding Cc: Greg Kroah-Hartman , Stephen Warren , Wolfram Sang , Grant Likely , Rob Herring , Benjamin Herrenschmidt , Thomas Gleixner , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 35 On Mon, Sep 16, 2013 at 10:31 AM, Thierry Reding wrote: > This is a version of irq_create_mapping() that propagates the precise > error code instead of returning 0 for all errors. It will be used in > subsequent patches to allow further propagation of error codes. > > To avoid code duplication, implement irq_create_mapping() as a wrapper > around the new __irq_create_mapping(). > > Signed-off-by: Thierry Reding Surprise! I don't like this. I think it is better to first go over the call sites and make them all handle negative return numbers rather than pushing the obscure __interface. I know from patch 0 that you think it's too much to change these 127 call sites but I don't think so, and I'm happy to merge one big patch changing all the 20 users in drivers/gpio. Likewise with the 11 consumers in drivers/pinctrl. It's just a a few archs+subsystems and it's just plain work. So do that first. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/