Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717Ab3IWUj5 (ORCPT ); Mon, 23 Sep 2013 16:39:57 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:46513 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709Ab3IWUjy (ORCPT ); Mon, 23 Sep 2013 16:39:54 -0400 Date: Mon, 23 Sep 2013 16:39:42 -0400 From: Neil Horman To: Joe Perches Cc: netdev@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org, Vlad Yasevich , linux-sctp@vger.kernel.org Subject: Re: [PATCH 12/12] sctp: Remove extern from function prototypes Message-ID: <20130923203942.GA2425@hmsreliant.think-freely.org> References: <445209f8885ccd8234fa787c30d63e63fc7917d7.1379961014.git.joe@perches.com> <6738b115d30d40f33c688863f5421d84d2aa706c.1379961014.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6738b115d30d40f33c688863f5421d84d2aa706c.1379961014.git.joe@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2220 Lines: 56 On Mon, Sep 23, 2013 at 11:37:59AM -0700, Joe Perches wrote: > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compiler. Its use is as unnecessary as > using auto to declare automatic/local variables in a block. > > Signed-off-by: Joe Perches > --- > include/net/sctp/sctp.h | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/include/net/sctp/sctp.h b/include/net/sctp/sctp.h > index 3794c5a..c5fe806 100644 > --- a/include/net/sctp/sctp.h > +++ b/include/net/sctp/sctp.h > @@ -90,12 +90,11 @@ > /* > * sctp/protocol.c > */ > -extern int sctp_copy_local_addr_list(struct net *, struct sctp_bind_addr *, > - sctp_scope_t, gfp_t gfp, > - int flags); > -extern struct sctp_pf *sctp_get_pf_specific(sa_family_t family); > -extern int sctp_register_pf(struct sctp_pf *, sa_family_t); > -extern void sctp_addr_wq_mgmt(struct net *, struct sctp_sockaddr_entry *, int); > +int sctp_copy_local_addr_list(struct net *, struct sctp_bind_addr *, > + sctp_scope_t, gfp_t gfp, int flags); > +struct sctp_pf *sctp_get_pf_specific(sa_family_t family); > +int sctp_register_pf(struct sctp_pf *, sa_family_t); > +void sctp_addr_wq_mgmt(struct net *, struct sctp_sockaddr_entry *, int); > > /* > * sctp/socket.c > @@ -110,7 +109,7 @@ void sctp_sock_rfree(struct sk_buff *skb); > void sctp_copy_sock(struct sock *newsk, struct sock *sk, > struct sctp_association *asoc); > extern struct percpu_counter sctp_sockets_allocated; > -extern int sctp_asconf_mgmt(struct sctp_sock *, struct sctp_sockaddr_entry *); > +int sctp_asconf_mgmt(struct sctp_sock *, struct sctp_sockaddr_entry *); > > /* > * sctp/primitive.c > -- > 1.8.1.2.459.gbcd45b4.dirty > > Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/